From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
davem@davemloft.net, linux@arm.linux.org.uk,
sebastian.hesselbarth@gmail.com, andrew@lunn.ch,
jason@lakedaemon.net, gregory.clement@free-electrons.com,
simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com,
xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com,
jaz@semihalf.com, tn@semihalf.com, <stable@vger.kernel.org>
Subject: Re: [PATCH v2 net 2/6] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG
Date: Thu, 26 Nov 2015 19:27:36 +0100 [thread overview]
Message-ID: <20151126192736.662634d3@free-electrons.com> (raw)
In-Reply-To: <1448561293-16431-3-git-send-email-mw@semihalf.com>
Dear Marcin Wojtas,
On Thu, 26 Nov 2015 19:08:09 +0100, Marcin Wojtas wrote:
> MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer
> allocation was mistakenly set as BIT(1). This commit fixes the assignment.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: <stable@vger.kernel.org> # v3.8+
> Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
> unit")
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What is the user-visible impact of this bug? Indeed, the code is wrong,
but things were working fine until now.
So I am not questioning that this patch should be merged, but only
questioning whether the stable tag is appropriate.
Same questions for your patch 3/6.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-11-26 18:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 18:08 [PATCH v2 net 0/6] Marvell Armada XP/370/38X Neta fixes Marcin Wojtas
2015-11-26 18:08 ` [PATCH v2 net 1/6] net: mvneta: add configuration for MBUS windows access protection Marcin Wojtas
2015-11-26 18:25 ` Thomas Petazzoni
2015-11-26 18:31 ` Marcin Wojtas
2015-11-26 18:08 ` [PATCH v2 net 2/6] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG Marcin Wojtas
2015-11-26 18:27 ` Thomas Petazzoni [this message]
2015-11-26 18:08 ` [PATCH v2 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable Marcin Wojtas
2015-11-26 18:08 ` [PATCH v2 net 4/6] net: mvneta: fix error path for building skb Marcin Wojtas
2015-11-26 18:38 ` Simon Guinot
2015-11-26 18:08 ` [PATCH v2 net 5/6] net: mvneta: enable setting custom TX IP checksum limit Marcin Wojtas
2015-11-26 18:08 ` [PATCH v2 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0 Marcin Wojtas
2015-11-26 18:33 ` Thomas Petazzoni
2015-11-26 18:41 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126192736.662634d3@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mw@semihalf.com \
--cc=myair@marvell.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nitroshift@yahoo.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=simon.guinot@sequanux.org \
--cc=stable@vger.kernel.org \
--cc=tn@semihalf.com \
--cc=xswang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).