From: David Miller <davem@redhat.com>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()
Date: Mon, 30 Nov 2015 11:06:07 -0500 (EST) [thread overview]
Message-ID: <20151130.110607.1409128209032271059.davem@redhat.com> (raw)
In-Reply-To: <1448488250.24696.40.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 25 Nov 2015 13:50:50 -0800
> diff --git a/include/net/sock.h b/include/net/sock.h
> index 7f89e4ba18d1..ead514332ae8 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -776,7 +776,7 @@ static inline int sk_memalloc_socks(void)
>
> static inline gfp_t sk_gfp_atomic(const struct sock *sk, gfp_t gfp_mask)
> {
> - return GFP_ATOMIC | (sk->sk_allocation & __GFP_MEMALLOC);
> + return gfp_mask | (sk->sk_allocation & __GFP_MEMALLOC);
> }
>
> static inline void sk_acceptq_removed(struct sock *sk)
Eric, please rename this to "sk_gfp_mask()" or "sk_gfp_flags()" or
something like that since it doesn't unconditionally use GFP_ATOMIC
any more.
Otherwise I'm %100 fine with this change.
Thank you.
next prev parent reply other threads:[~2015-11-30 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 21:50 [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack() Eric Dumazet
2015-11-25 22:08 ` Aaron Conole
2015-11-25 22:32 ` Eric Dumazet
2015-11-25 22:35 ` Eric Dumazet
2015-11-26 3:17 ` Aaron Conole
2015-11-26 3:29 ` Eric Dumazet
2015-11-28 2:21 ` Aaron Conole
2015-11-30 16:06 ` David Miller [this message]
2015-11-30 16:57 ` [PATCH v2 " Eric Dumazet
2015-12-03 4:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130.110607.1409128209032271059.davem@redhat.com \
--to=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).