From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet_out clock Date: Tue, 1 Dec 2015 08:24:50 +0100 Message-ID: <20151201082450.6a4a9421@ipc1.ka-ro> References: <1448883168-30742-1-git-send-email-LW@KARO-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Lunn , "David S. Miller" , Fabio Estevam , Greg Ungerer , Kevin Hao , Lucas Stach , Philippe Reynes , Richard Cochran , Russell King , Sascha Hauer , "Stefan Agner" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Jeff Kirsher , "Uwe Kleine-K?nig" To: Duan Andy Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi, > From: Lothar Wa=C3=9Fmann Sent: Monday, Nove= mber 30, 2015 7:33 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Greg Ungere= r; > > Kevin Hao; Lothar Wa=C3=9Fmann; Lucas Stach; Duan Fugang-B38611; Ph= ilippe > > Reynes; Richard Cochran; Russell King; Sascha Hauer; Stefan Agner; = linux- > > kernel@vger.kernel.org; netdev@vger.kernel.org; Jeff Kirsher; Uwe K= leine- > > K=C3=B6nig > > Subject: [PATCH 0/3] net: fec: Reset ethernet PHY whenever the enet= _out > > clock > >=20 > > This patchset fixes a regression introduced by commit 8fff755e9f8d = ("net: > > fec: Ensure clocks are enabled while using mdio bus") for ethernet = PHYs > > that are using ENET_OUT as reference clock (on i.MX6 or i.MX28) > >=20 > Do you mean commit 8fff755e9f8d cause your problem ? This commit jus= t manage ipg clock in runtime because mdio bus can access external phy = switch no matter netdev status. >=20 No. Actually I meant commit e8fcfcd5684a ("net: fec: optimize the clock= management to save power") which started to disable the clocks when not in use. Sorry for the confusion, Lothar Wa=C3=9Fmann