From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: <kan.liang@intel.com>, <netdev@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>, <davem@davemloft.net>,
<andi@firstfloor.org>, <jeffrey.t.kirsher@intel.com>,
<shannon.nelson@intel.com>, <carolyn.wyborny@intel.com>,
<donald.c.skidmore@intel.com>, <matthew.vick@intel.com>,
<john.ronciak@intel.com>, <mitch.a.williams@intel.com>,
<john.r.fastabend@intel.com>, <ogerlitz@mellanox.com>,
<edumazet@google.com>, <jiri@mellanox.com>, <sfeldma@gmail.com>,
<gospo@cumulusnetworks.com>, <sasha.levin@oracle.com>,
<dsahern@gmail.com>, <tj@kernel.org>, <cascardo@redhat.com>,
<corbet@lwn.net>
Subject: Re: [RFC 1/4] net: support per queue tx_usecs in sysfs
Date: Tue, 1 Dec 2015 15:44:54 -0800 [thread overview]
Message-ID: <20151201154454.000041a3@unknown> (raw)
In-Reply-To: <565E1B8E.4040603@gmail.com>
On Tue, 1 Dec 2015 14:13:34 -0800
Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 01/12/15 00:01, kan.liang@intel.com wrote:
> > From: Kan Liang <kan.liang@intel.com>
> >
> > Network devices usually have many queues. Each queue has its own
> > tx_usecs options. Currently, we can only set all the queues with same
> > value by ethtool. This patch expose the tx_usecs in sysfs. So the user
> > can set/get per queue coalesce parameter tx_usecs by sysfs.
>
> The new interface you propose makes things inconsistent, since we have
> two separate configuration paths (sysfs and ethtool), and it would seem
> better to have per-queue awareness in ethtool, since there is a whole
> bunch of other parameters that could be configured on a per-queue basis.
>
> Have you tried to extend existing ethtool interfaces to cover the need
> for multiple queues?
While I agree that ethtool provides a similar functionality, ethtool
was designed (particularly the ethtool -C/c commands) around one queue
NICs. We can't change the output or functionality of the user
interface without breaking a bunch of user's scripts and stuff.
With this effort, Kan is laying groundwork for making further kernel
changes, and having the kernel call back in to drivers via ethtool
mechanisms that were designed before multiple queue adapters.
We can also next migrate the legacy ethtool interfaces to use these
new .ndo_ops should we wish.
These patches were provided with the intent of getting some feedback
about going down this path of making a *consistent* user interface that
is driver agnostic in sysfs, and supports multiple queue adapters.
next prev parent reply other threads:[~2015-12-01 23:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 8:01 [RFC 1/4] net: support per queue tx_usecs in sysfs kan.liang
2015-12-01 8:01 ` [RFC 2/4] i40e: handle per queue tx_usecs setting kan.liang
2015-12-01 8:01 ` [RFC 3/4] net: support per queue rx_usecs in sysfs kan.liang
2015-12-01 8:01 ` [RFC 4/4] i40e: handle per queue rx_usecs setting kan.liang
2015-12-01 19:47 ` Stephen Hemminger
2015-12-01 22:13 ` [RFC 1/4] net: support per queue tx_usecs in sysfs Florian Fainelli
2015-12-01 23:44 ` Jesse Brandeburg [this message]
2015-12-02 1:57 ` Alexander Duyck
2015-12-02 2:27 ` David Miller
2015-12-02 2:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201154454.000041a3@unknown \
--to=jesse.brandeburg@intel.com \
--cc=andi@firstfloor.org \
--cc=carolyn.wyborny@intel.com \
--cc=cascardo@redhat.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@mellanox.com \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=kan.liang@intel.com \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=sasha.levin@oracle.com \
--cc=sfeldma@gmail.com \
--cc=shannon.nelson@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).