From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Gospodarek <gospo@cumulusnetworks.com>
Subject: Re: [patch net-next 24/26] mlxsw: spectrum: Implement LAG port
 join/leave
Date: Wed, 2 Dec 2015 06:01:32 -0800
Message-ID: <20151202140130.GP18107@gospo.home.greyhouse.net>
References: <1448977744-17930-1-git-send-email-jiri@resnulli.us>
 <1448977744-17930-25-git-send-email-jiri@resnulli.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
	eladr@mellanox.com, yotamg@mellanox.com, ogerlitz@mellanox.com
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ob0-f174.google.com ([209.85.214.174]:36167 "EHLO
	mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758227AbbLBOBg (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 2 Dec 2015 09:01:36 -0500
Received: by obcse5 with SMTP id se5so29431760obc.3
        for <netdev@vger.kernel.org>; Wed, 02 Dec 2015 06:01:36 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1448977744-17930-25-git-send-email-jiri@resnulli.us>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Dec 01, 2015 at 02:49:02PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> Implement basic procedures for joining/leaving port to/from LAG. That
> includes HW setup of collector, core LAG mapping setup.
> 
[...]
> @@ -1937,6 +2153,18 @@ static int mlxsw_sp_netdevice_event(struct notifier_block *unused,
>  				mlxsw_sp_port->bridged = 0;
>  				mlxsw_sp_master_bridge_dec(mlxsw_sp, upper_dev);
>  			}
> +		} else if (netif_is_lag_master(upper_dev)) {
> +			if (info->linking) {
> +				err = mlxsw_sp_port_lag_join(mlxsw_sp_port,
> +							     upper_dev);
> +				if (err)
> +					netdev_err(dev, "Failed to join link aggregation\n");
> +			} else {
> +				err = mlxsw_sp_port_lag_leave(mlxsw_sp_port,
> +							      upper_dev);
> +				if (err)
> +					netdev_err(dev, "Failed to leave link aggregation\n");
> +			}
>  		}
>  		break;
>  	}

If I'm reading this correctly, moving an offloaded port into a bond/team
or changing configuration options isn't synchronous.  It seems like the
lack of immediate feedback to the caller is not desired.