From: Flavio Leitner <fbl@sysclose.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Pravin B Shelar <pshelar@nicira.com>,
Thomas Graf <tgraf@suug.ch>,
dev@openvswitch.org
Subject: Re: [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion
Date: Wed, 2 Dec 2015 13:58:17 -0200 [thread overview]
Message-ID: <20151202155817.GA8829@x240.home> (raw)
In-Reply-To: <d3c53f79dfaacd71bebf97427388d60dc5652eae.1448989843.git.pabeni@redhat.com>
On Tue, Dec 01, 2015 at 06:33:36PM +0100, Paolo Abeni wrote:
> Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference
> to the underlying tunnel device, but never released it when such
> device is deleted.
> Deleting the underlying device via the ip tool cause the kernel to
> hangup in the netdev_wait_allrefs() loop.
> This commit ensure that on device unregistration dp_detach_port_notify()
> is called for all vports that hold the device reference, properly
> releasing it.
>
> Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device")
> Fixes: b2acd1dc3949 ("openvswitch: Use regular GRE net_device instead of vport")
> Fixes: 6b001e682e90 ("openvswitch: Use Geneve device.")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
LGTM and fixes the issue in my env.
Acked-by: Flavio Leitner <fbl@sysclose.org>
next prev parent reply other threads:[~2015-12-02 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 17:33 [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion Paolo Abeni
2015-12-02 15:58 ` Flavio Leitner [this message]
[not found] ` <d3c53f79dfaacd71bebf97427388d60dc5652eae.1448989843.git.pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-02 23:00 ` Pravin Shelar
2015-12-03 19:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202155817.GA8829@x240.home \
--to=fbl@sysclose.org \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@nicira.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).