From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: gerlitz.or@gmail.com, netdev@vger.kernel.org
Subject: Re: [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface
Date: Wed, 2 Dec 2015 23:35:31 +0100 [thread overview]
Message-ID: <20151202223531.GQ2355@nanopsycho.orion> (raw)
In-Reply-To: <20151202.172847.1855287186918935450.davem@davemloft.net>
Wed, Dec 02, 2015 at 11:28:47PM CET, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Wed, 2 Dec 2015 23:25:52 +0100
>
>> Again, there is no possible way to achieve this bugon, other than a
>> stack corruption. I don't think we should try to cope with a stack
>> corruption.
>
>Then remove the assertion.
I thought that in cases like this it is better to just assert and tell
user that something went horribly and non-recoverably wrong.
Why to continue to work if we know that we are making things wrong
(incorrect structure initialization in this case) ? What am I missing?
next prev parent reply other threads:[~2015-12-02 22:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 12:45 [patch net-next v2 0/6] mlxsw: driver update Jiri Pirko
2015-11-27 12:45 ` [patch net-next v2 1/6] mlxsw: reg: Add Management LED Control register definition Jiri Pirko
2015-11-27 12:45 ` [patch net-next v2 2/6] mlxsw: spectrum: Add support for port identification Jiri Pirko
2015-11-27 12:45 ` [patch net-next v2 3/6] mlxsw: reg: Add definition of temperature management registers Jiri Pirko
2015-11-27 12:45 ` [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface Jiri Pirko
2015-11-29 9:04 ` Or Gerlitz
2015-11-29 10:49 ` Jiri Pirko
2015-12-02 22:05 ` Or Gerlitz
2015-12-02 22:25 ` Jiri Pirko
2015-12-02 22:28 ` David Miller
2015-12-02 22:35 ` Jiri Pirko [this message]
2015-12-02 23:37 ` David Miller
2015-12-03 8:19 ` Jiri Pirko
2015-12-03 9:32 ` Or Gerlitz
2015-12-03 9:55 ` Jiri Pirko
2015-11-27 12:45 ` [patch net-next v2 5/6] mlxsw: reg: Add definition of fan management registers Jiri Pirko
2015-11-27 12:45 ` [patch net-next v2 6/6] mlxsw: core: Implement fan control using hwmon Jiri Pirko
2015-11-30 20:06 ` [patch net-next v2 0/6] mlxsw: driver update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202223531.GQ2355@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox