From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: davej@codemonkey.org.uk, netdev@vger.kernel.org
Subject: Re: 4.4-rc2 xfrm_lookup kasan trace
Date: Thu, 03 Dec 2015 11:59:18 -0500 (EST) [thread overview]
Message-ID: <20151203.115918.730123340200500473.davem@davemloft.net> (raw)
In-Reply-To: <1448932931.25582.2.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 30 Nov 2015 17:22:11 -0800
> @@ -2198,6 +2198,7 @@ struct dst_entry *xfrm_lookup(struct net *net, struct dst_entry *dst_orig,
> xdst = NULL;
> route = NULL;
>
> + sk = sk_to_full_sk((struct sock *)sk);
The war against const...
I know this is the only instance where const is input, but you may want to
consider adding the const verion of the helper anyways to avoid ugly casts
like this.
next prev parent reply other threads:[~2015-12-03 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 23:27 4.4-rc2 xfrm_lookup kasan trace Dave Jones
2015-12-01 1:22 ` Eric Dumazet
2015-12-03 16:59 ` David Miller [this message]
2015-12-03 17:09 ` Eric Dumazet
2015-12-03 22:27 ` Eric Dumazet
2015-12-08 14:35 ` David Laight
2015-12-07 16:53 ` [PATCH net] xfrm: take care of request sockets Eric Dumazet
2015-12-07 22:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203.115918.730123340200500473.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@codemonkey.org.uk \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).