From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion Date: Thu, 03 Dec 2015 14:30:48 -0500 (EST) Message-ID: <20151203.143048.662288701351689156.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, pshelar@nicira.com, tgraf@suug.ch, dev@openvswitch.org, fbl@sysclose.org To: pabeni@redhat.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:43852 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbbLCTau (ORCPT ); Thu, 3 Dec 2015 14:30:50 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Paolo Abeni Date: Tue, 1 Dec 2015 18:33:36 +0100 > Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference > to the underlying tunnel device, but never released it when such > device is deleted. > Deleting the underlying device via the ip tool cause the kernel to > hangup in the netdev_wait_allrefs() loop. > This commit ensure that on device unregistration dp_detach_port_notify() > is called for all vports that hold the device reference, properly > releasing it. > > Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device") > Fixes: b2acd1dc3949 ("openvswitch: Use regular GRE net_device instead of vport") > Fixes: 6b001e682e90 ("openvswitch: Use Geneve device.") > Signed-off-by: Paolo Abeni Applied and queued up for -stable, thank you.