From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface Date: Thu, 3 Dec 2015 10:55:14 +0100 Message-ID: <20151203095514.GD2331@nanopsycho.orion> References: <20151202222551.GP2355@nanopsycho.orion> <20151202.172847.1855287186918935450.davem@davemloft.net> <20151202223531.GQ2355@nanopsycho.orion> <20151202.183758.91764299340813651.davem@davemloft.net> <20151203081931.GA2331@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , Linux Netdev List To: Or Gerlitz Return-path: Received: from mail-wm0-f50.google.com ([74.125.82.50]:34160 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932645AbbLCJzR (ORCPT ); Thu, 3 Dec 2015 04:55:17 -0500 Received: by wmvv187 with SMTP id v187so18510719wmv.1 for ; Thu, 03 Dec 2015 01:55:16 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Thu, Dec 03, 2015 at 10:32:04AM CET, gerlitz.or@gmail.com wrote: >On Thu, Dec 3, 2015 at 10:19 AM, Jiri Pirko wrote: >> Thu, Dec 03, 2015 at 12:37:58AM CET, davem@davemloft.net wrote: >>>From: Jiri Pirko >>>Date: Wed, 2 Dec 2015 23:35:31 +0100 >>> >>>> Why to continue to work if we know that we are making things wrong >>>> (incorrect structure initialization in this case) ? What am I missing? >>> >>>The user might be able to continue to have connectivity and >>>report the problem. >>> >>>BUG_ON() is really a hard hammer. >> >> Okay. > >So we are removing this as well, right? Changing it to WARN: http://patchwork.ozlabs.org/patch/552087/