netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: "Bowers, AndrewX" <andrewx.bowers@intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	David Miller <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM
Date: Thu, 3 Dec 2015 11:58:50 -0500	[thread overview]
Message-ID: <20151203165850.GB15262@oracle.com> (raw)
In-Reply-To: <26D9FDECA4FBDD4AADA65D8E2FC68A4A0F96CBB6@ORSMSX104.amr.corp.intel.com>

On (12/03/15 16:53), Bowers, AndrewX wrote:

> 
> I get an error -11 on driver init with this patch applied, I can
> revert it and everything works normally. Dmesg screenshot is attached,
> can supply complete dmesg log if needed.

Yes, that's the same thing that I'm running into as well. 
Using this patch makes this work. But this adds some ugly
ifdef's, and other methods should be explored.

--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -9102,9 +9102,11 @@ struct i40e_vsi *i40e_vsi_setup(struct i40e_pf *pf, u8 ty
                ret = i40e_config_netdev(vsi);
                if (ret)
                        goto err_netdev;
+#if defined(CONFIG_SPARC) || defined(CONFIG_OF)
                ret = i40e_macaddr_init(vsi, pf->hw.mac.addr);
                if (ret)
                        goto err_netdev;
+#endif
                ret = register_netdev(vsi->netdev);
                if (ret)
                        goto err_netdev;

      reply	other threads:[~2015-12-03 16:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 23:21 [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM Sowmini Varadhan
2015-11-05  0:01 ` Nelson, Shannon
2015-11-05 15:31 ` David Miller
2015-11-05 16:05   ` David Miller
2015-11-05 16:28     ` Sowmini Varadhan
2015-11-05 16:29       ` David Miller
2015-11-05 17:12         ` Sowmini Varadhan
2015-11-05 17:41         ` Nelson, Shannon
2015-11-05 18:13     ` Andy Shevchenko
2015-11-05 18:31       ` David Miller
2015-11-05 19:32         ` Andy Shevchenko
2015-12-03 16:53           ` [Intel-wired-lan] " Bowers, AndrewX
2015-12-03 16:58             ` Sowmini Varadhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151203165850.GB15262@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=andrewx.bowers@intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).