From: David Miller <davem@davemloft.net>
To: alexei.starovoitov@gmail.com
Cc: dvyukov@google.com, ast@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller@googlegroups.com,
kcc@google.com, glider@google.com, sasha.levin@oracle.com,
edumazet@google.com, ryabinin.a.a@gmail.com
Subject: Re: bpf: undefined shift in __bpf_prog_run
Date: Fri, 04 Dec 2015 14:26:51 -0500 (EST) [thread overview]
Message-ID: <20151204.142651.968075964630586979.davem@davemloft.net> (raw)
In-Reply-To: <20151204191013.GB45508@ast-mbp.thefacebook.com>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Fri, 4 Dec 2015 11:10:15 -0800
> just don't generate random bpf programs with such shifts.
Agreed, it is exactly the same as if the compiler emitted real cpu
shift instructions with undefined behavior.
The creator of the BPF code in question is what should be fixed.
next prev parent reply other threads:[~2015-12-04 19:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 11:17 bpf: undefined shift in __bpf_prog_run Dmitry Vyukov
2015-12-04 18:43 ` Alexei Starovoitov
2015-12-04 19:03 ` Dmitry Vyukov
2015-12-04 19:10 ` Alexei Starovoitov
2015-12-04 19:26 ` David Miller [this message]
2015-12-04 19:48 ` Dmitry Vyukov
2015-12-04 20:35 ` Alexei Starovoitov
[not found] ` <CAN=P9ph-_w-ekSabGGKq-pu50enZXfGWp3k=x9zTb=Xy+ccjwA@mail.gmail.com>
2015-12-04 20:50 ` Alexei Starovoitov
2015-12-04 21:37 ` David Miller
2015-12-04 21:21 ` Hannes Frederic Sowa
2015-12-07 11:14 ` David Laight
2015-12-09 18:04 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204.142651.968075964630586979.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryabinin.a.a@gmail.com \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).