From: Jiri Benc <jbenc@redhat.com>
To: Tom Herbert <tom@herbertland.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Thomas Graf <tgraf@suug.ch>
Subject: Re: [RFC PATCH net] vxlan: fix incorrect RCO bit in VXLAN header
Date: Fri, 4 Dec 2015 18:06:10 +0100 [thread overview]
Message-ID: <20151204180610.51732e36@griffin> (raw)
In-Reply-To: <CALx6S35_CbKfNpGJM6xsSgdkd25iekMCS3jwyG7_B5bCfeJhQw@mail.gmail.com>
On Fri, 4 Dec 2015 08:43:59 -0800, Tom Herbert wrote:
> What a mess VXLAN has become. There are no guidelines or order in
> defining these reserved bits! If anyone is looking to do some work in
> encapsulation please consider bringing up VXLAN-GPE/NSH in the stack,
> hopefully that world will be better....
I'm actually working right now on VXLAN-GPE implementation (and tons of
cleanups in the vxlan code) which is the reason I noticed this bug.
> Acked-by: Tom Herbert <tom@herbertland.com>
Thanks. David, as this was submitted as RFC, should I resubmit?
Provided that you're okay with the patch, of course; it changes the
on-wire format which should not be taken lightly, even though the
current behavior is incorrect.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-12-04 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 12:54 [RFC PATCH net] vxlan: fix incorrect RCO bit in VXLAN header Jiri Benc
2015-12-04 16:43 ` Tom Herbert
2015-12-04 17:06 ` Jiri Benc [this message]
2015-12-04 17:13 ` Tom Herbert
2015-12-07 10:48 ` Jiri Benc
2015-12-05 23:16 ` David Miller
2015-12-07 15:46 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204180610.51732e36@griffin \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).