* [PATCH] net: remove unnecessary semicolon in netdev_alloc_pcpu_stats()
@ 2015-12-05 12:58 Felix Fietkau
2015-12-05 17:11 ` Pablo Neira Ayuso
2015-12-07 3:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Felix Fietkau @ 2015-12-05 12:58 UTC (permalink / raw)
To: netdev; +Cc: kaloz, pablo
This semicolon causes a build error if the function call is wrapped in
parentheses.
Fixes: aabc92bbe3cf ("net: add __netdev_alloc_pcpu_stats() to indicate gfp flags")
Reported-by: Imre Kaloz <kaloz@openwrt.org>
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
include/linux/netdevice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 7d2d1d7..f2f91d9 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2103,7 +2103,7 @@ struct pcpu_sw_netstats {
})
#define netdev_alloc_pcpu_stats(type) \
- __netdev_alloc_pcpu_stats(type, GFP_KERNEL);
+ __netdev_alloc_pcpu_stats(type, GFP_KERNEL)
#include <linux/notifier.h>
--
2.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: remove unnecessary semicolon in netdev_alloc_pcpu_stats()
2015-12-05 12:58 [PATCH] net: remove unnecessary semicolon in netdev_alloc_pcpu_stats() Felix Fietkau
@ 2015-12-05 17:11 ` Pablo Neira Ayuso
2015-12-07 3:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2015-12-05 17:11 UTC (permalink / raw)
To: Felix Fietkau; +Cc: netdev, kaloz
On Sat, Dec 05, 2015 at 01:58:11PM +0100, Felix Fietkau wrote:
> This semicolon causes a build error if the function call is wrapped in
> parentheses.
>
> Fixes: aabc92bbe3cf ("net: add __netdev_alloc_pcpu_stats() to indicate gfp flags")
> Reported-by: Imre Kaloz <kaloz@openwrt.org>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: remove unnecessary semicolon in netdev_alloc_pcpu_stats()
2015-12-05 12:58 [PATCH] net: remove unnecessary semicolon in netdev_alloc_pcpu_stats() Felix Fietkau
2015-12-05 17:11 ` Pablo Neira Ayuso
@ 2015-12-07 3:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-12-07 3:32 UTC (permalink / raw)
To: nbd; +Cc: netdev, kaloz, pablo
From: Felix Fietkau <nbd@openwrt.org>
Date: Sat, 5 Dec 2015 13:58:11 +0100
> This semicolon causes a build error if the function call is wrapped in
> parentheses.
>
> Fixes: aabc92bbe3cf ("net: add __netdev_alloc_pcpu_stats() to indicate gfp flags")
> Reported-by: Imre Kaloz <kaloz@openwrt.org>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Good catch, applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-07 3:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-05 12:58 [PATCH] net: remove unnecessary semicolon in netdev_alloc_pcpu_stats() Felix Fietkau
2015-12-05 17:11 ` Pablo Neira Ayuso
2015-12-07 3:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).