From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: davej@codemonkey.org.uk, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: sctp: fix lockdep splat in sctp_v6_get_dst()
Date: Mon, 07 Dec 2015 17:07:45 -0500 (EST) [thread overview]
Message-ID: <20151207.170745.1345382498039990120.davem@davemloft.net> (raw)
In-Reply-To: <1449505521.25029.65.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 07 Dec 2015 08:25:21 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> While cooking the sctp np->opt rcu fixes, I forgot to move
> one rcu_read_unlock() after the added rcu_dereference() in
> sctp_v6_get_dst()
>
> This gave lockdep warnings reported by Dave Jones.
>
> Fixes: c836a8ba9386 ("ipv6: sctp: add rcu protection around np->opt")
> Reported-by: Dave Jones <davej@codemonkey.org.uk>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2015-12-07 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 0:25 suspicious rcu_dereference_check in sctp_v6_get_dst Dave Jones
2015-12-06 1:13 ` Eric Dumazet
2015-12-06 1:37 ` Dave Jones
2015-12-06 1:56 ` Eric Dumazet
2015-12-07 16:25 ` [PATCH net] ipv6: sctp: fix lockdep splat in sctp_v6_get_dst() Eric Dumazet
2015-12-07 22:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207.170745.1345382498039990120.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@codemonkey.org.uk \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).