From: Stefan Hajnoczi <stefanha@redhat.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, kbuild-all@01.org,
Matt Benjamin <mbenjamin@redhat.com>, Asias He <asias@redhat.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
matt.ma@linaro.org
Subject: Re: [PATCH] VSOCK: fix returnvar.cocci warnings
Date: Mon, 7 Dec 2015 09:50:08 +0800 [thread overview]
Message-ID: <20151207015008.GA32667@stefanha-x1.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.02.1512060654580.2030@localhost6.localdomain6>
[-- Attachment #1.1: Type: text/plain, Size: 819 bytes --]
On Sun, Dec 06, 2015 at 06:56:23AM +0100, Julia Lawall wrote:
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Asias He <asias@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>
> ---
>
> vsock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -56,8 +56,7 @@ struct vhost_vsock {
>
> static u32 vhost_transport_get_local_cid(void)
> {
> - u32 cid = VHOST_VSOCK_DEFAULT_HOST_CID;
> - return cid;
> + return VHOST_VSOCK_DEFAULT_HOST_CID;
> }
>
> static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2015-12-07 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 5:56 [PATCH] VSOCK: fix returnvar.cocci warnings Julia Lawall
2015-12-07 1:50 ` Stefan Hajnoczi [this message]
2015-12-07 3:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207015008.GA32667@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=asias@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=kvm@vger.kernel.org \
--cc=matt.ma@linaro.org \
--cc=mbenjamin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox