From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: jesse@kernel.org, linville@tuxdriver.com, netdev@vger.kernel.org,
jesse@nicira.com, kernel-team@fb.com
Subject: Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support
Date: Tue, 08 Dec 2015 21:20:14 -0500 (EST) [thread overview]
Message-ID: <20151208.212014.293664653825079141.davem@davemloft.net> (raw)
In-Reply-To: <CALx6S37o+gQ4BLtphsDzbg-qPsiZo2_7TvhSdweLy8wAEbbjNw@mail.gmail.com>
From: Tom Herbert <tom@herbertland.com>
Date: Tue, 8 Dec 2015 16:11:56 -0800
> I thought about a TLV implementation but there is no base support in
> the kernel for it. It would be great if you could implement the TLV
> loop. Honestly, though, I'm still very leery of the processing
> overhead associated with TLVs in the critical data path. In the
> worst case of RCO we would need to fish for the RCO option though
> the TLV list in both the GRO and normal path for each packet. If the
> TLV lists are long then performance may be negatively affected
> mitigating the value of RCO (needs to be measured).
Open ended TLVs are to me likened to an attack vector waiting to
happen, for the reasons Tom listed.
next prev parent reply other threads:[~2015-12-09 2:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 18:27 [PATCH net-next 0/3] geneve: Add support for Remote Checksum Offload Tom Herbert
2015-12-08 18:27 ` [PATCH net-next 1/3] rco: Clean up casting errors Tom Herbert
2015-12-08 18:27 ` [PATCH net-next 2/3] geneve: UDP checksum configuration via netlink Tom Herbert
2015-12-08 19:27 ` John W. Linville
2015-12-08 18:27 ` [PATCH net-next 3/3] geneve: Remote Checksum Offload support Tom Herbert
2015-12-08 19:31 ` John W. Linville
2015-12-08 19:59 ` Tom Herbert
2015-12-08 23:58 ` Jesse Gross
2015-12-09 0:11 ` Tom Herbert
2015-12-09 1:13 ` Jesse Gross
2015-12-09 2:20 ` David Miller [this message]
2015-12-08 20:45 ` kbuild test robot
2015-12-08 20:45 ` [PATCH] geneve: fix noderef.cocci warnings kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208.212014.293664653825079141.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@kernel.org \
--cc=jesse@nicira.com \
--cc=kernel-team@fb.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).