From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: tgraf@suug.ch, eric.dumazet@gmail.com, josh@joshtriplett.org,
paulmck@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: rhashtable: Remove unnecessary wmb for future_tbl
Date: Tue, 08 Dec 2015 22:47:08 -0500 (EST) [thread overview]
Message-ID: <20151208.224708.473911814887888793.davem@davemloft.net> (raw)
In-Reply-To: <20151208090904.GA17605@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 8 Dec 2015 17:09:04 +0800
> The patch 9497df88ab5567daa001829051c5f87161a81ff0 ("rhashtable:
> Fix reader/rehash race") added a pair of barriers. In fact the
> wmb is superfluous because every subsequent write to the old or
> new hash table uses rcu_assign_pointer, which itself carriers a
> full barrier prior to the assignment.
>
> Therefore we may remove the explicit wmb.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-next.
prev parent reply other threads:[~2015-12-09 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 9:09 rhashtable: Remove unnecessary wmb for future_tbl Herbert Xu
2015-12-09 2:52 ` Thomas Graf
2015-12-09 3:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208.224708.473911814887888793.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=josh@joshtriplett.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).