From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: [PATCH net] geneve: Fix IPv6 xmit stats update. Date: Tue, 8 Dec 2015 09:54:11 -0500 Message-ID: <20151208145410.GC3598@tuxdriver.com> References: <1449544650-6112-1-git-send-email-pshelar@nicira.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: Pravin B Shelar Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:53623 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756730AbbLHPAO (ORCPT ); Tue, 8 Dec 2015 10:00:14 -0500 Content-Disposition: inline In-Reply-To: <1449544650-6112-1-git-send-email-pshelar@nicira.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Dec 07, 2015 at 07:17:30PM -0800, Pravin B Shelar wrote: > Call to iptunnel_xmit_stats() is not required after udp-tunnel6-xmit. > By calling iptunnel_xmit_stats() results in incorrect device stats. > Following patch drops this call. > > Signed-off-by: Pravin B Shelar > --- > drivers/net/geneve.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index de5c30c..c2b79f5 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -967,8 +967,6 @@ static netdev_tx_t geneve6_xmit_skb(struct sk_buff *skb, struct net_device *dev, > err = udp_tunnel6_xmit_skb(dst, gs6->sock->sk, skb, dev, > &fl6.saddr, &fl6.daddr, prio, ttl, > sport, geneve->dst_port, !udp_csum); > - > - iptunnel_xmit_stats(err, &dev->stats, dev->tstats); > return NETDEV_TX_OK; > > tx_error: So udp_tunnel_xmit_skb and udp_tunnel6_xmit_skb are different in this regard? It seems so -- who knew? :-) _Should_ they be different in this regard? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.