From: Dan Carpenter <dan.carpenter@oracle.com>
To: "David S. Miller" <davem@davemloft.net>, Asias He <asias@redhat.com>
Cc: Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
kernel-janitors@vger.kernel.org
Subject: [patch -next] VSOCK: signedness bug in virtio_transport_dgram_enqueue()
Date: Wed, 9 Dec 2015 13:27:13 +0300 [thread overview]
Message-ID: <20151209102713.GG3173@mwanda> (raw)
"written" has to be signed for the error handling to work.
trans->ops->send_pkt() returns an int so that's fine.
Fixes: 80a19e338d45 ('VSOCK: Introduce virtio-vsock-common.ko')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index 28f790d..d9a2325 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -815,7 +815,8 @@ virtio_transport_dgram_enqueue(struct vsock_sock *vsk,
.type = VIRTIO_VSOCK_TYPE_DGRAM,
.msg = msg,
};
- size_t total_written = 0, pkt_off = 0, written;
+ size_t total_written = 0, pkt_off = 0;
+ int written;
u16 dgram_id;
/* The max size of a single dgram we support is 64KB */
@@ -845,7 +846,7 @@ virtio_transport_dgram_enqueue(struct vsock_sock *vsk,
}
total_written += written;
pkt_off += written;
- pr_debug("%s:id=%d, dgram_len=%zu, off=%zu, total_written=%zu, written=%zu\n",
+ pr_debug("%s:id=%d, dgram_len=%zu, off=%zu, total_written=%zu, written=%d\n",
__func__, dgram_id, dgram_len, pkt_off, total_written, written);
}
next reply other threads:[~2015-12-09 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:27 Dan Carpenter [this message]
2015-12-10 2:21 ` [patch -next] VSOCK: signedness bug in virtio_transport_dgram_enqueue() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209102713.GG3173@mwanda \
--to=dan.carpenter@oracle.com \
--cc=asias@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=jonmason@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).