* [patch -next] mlxsw: spectrum: fix some error handling
@ 2015-12-09 10:33 Dan Carpenter
2015-12-09 10:47 ` Jiri Pirko
2015-12-12 1:15 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-12-09 10:33 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Ido Schimmel, netdev, kernel-janitors
The "err = " assignment is missing here.
Fixes: 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 3ec07b9..322ed54 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -2091,7 +2091,7 @@ static int mlxsw_sp_port_lag_leave(struct mlxsw_sp_port *mlxsw_sp_port,
err = mlxsw_sp_lag_col_port_disable(mlxsw_sp_port, lag_id);
if (err)
return err;
- mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id);
+ err = mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id);
if (err)
return err;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch -next] mlxsw: spectrum: fix some error handling
2015-12-09 10:33 [patch -next] mlxsw: spectrum: fix some error handling Dan Carpenter
@ 2015-12-09 10:47 ` Jiri Pirko
2015-12-12 1:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2015-12-09 10:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors
Wed, Dec 09, 2015 at 11:33:51AM CET, dan.carpenter@oracle.com wrote:
>The "err = " assignment is missing here.
>
>Fixes: 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave')
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch -next] mlxsw: spectrum: fix some error handling
2015-12-09 10:33 [patch -next] mlxsw: spectrum: fix some error handling Dan Carpenter
2015-12-09 10:47 ` Jiri Pirko
@ 2015-12-12 1:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-12-12 1:15 UTC (permalink / raw)
To: dan.carpenter; +Cc: jiri, idosch, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 9 Dec 2015 13:33:51 +0300
> The "err = " assignment is missing here.
>
> Fixes: 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-12 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 10:33 [patch -next] mlxsw: spectrum: fix some error handling Dan Carpenter
2015-12-09 10:47 ` Jiri Pirko
2015-12-12 1:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).