From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, hannes@stressinduktion.org
Subject: Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values
Date: Fri, 11 Dec 2015 20:21:57 -0500 (EST) [thread overview]
Message-ID: <20151211.202157.2045048466167764855.davem@davemloft.net> (raw)
In-Reply-To: <b813d147f9f4c938fbe4c3e0e671e88b2afcf412.1449678473.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Thu, 10 Dec 2015 00:27:53 +0800
> Add the support for adding expire value to routes, requested by
> Tom Gundersen <teg@jklm.no> for systemd-networkd, and NetworkManager
> wants it too.
>
> add it by using the field rta_expires of rta_cacheinfo
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
This is the wrong way to do this.
Currently we only ever dump rta_cacheinfo values to the user.
If we use it to set things, we have to completely consider every
member of that structure as potentially having meaning either
intended by the user or choosen by us in the future.
Therefore it is a poor choice to start using for specifying the
expires value, and some other mechanism such as a new RTNETLINK
attribute, should be used for this.
next prev parent reply other threads:[~2015-12-12 1:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 16:27 [PATCHv2 net-next] ipv6: allow routes to be configured with expire values Xin Long
2015-12-12 1:21 ` David Miller [this message]
2015-12-14 11:48 ` Xin Long
2015-12-14 17:16 ` Hannes Frederic Sowa
2015-12-14 19:36 ` David Miller
2015-12-16 9:45 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211.202157.2045048466167764855.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).