From: David Miller <davem@davemloft.net>
To: wens@csie.org
Cc: peppe.cavallaro@st.com, maxime.ripard@free-electrons.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, manabian@gmail.com
Subject: Re: [PATCH net] stmmac: dwmac-sunxi: Call exit cleanup function in probe error path
Date: Mon, 14 Dec 2015 16:12:18 -0500 (EST) [thread overview]
Message-ID: <20151214.161218.2057176608170714361.davem@davemloft.net> (raw)
In-Reply-To: <1449828229-10720-1-git-send-email-wens@csie.org>
From: Chen-Yu Tsai <wens@csie.org>
Date: Fri, 11 Dec 2015 18:03:49 +0800
> dwmac-sunxi has 2 callbacks that were called from stmmac_platform as
> part of the probe and remove sequences.
>
> Ater the conversion of dwmac-sunxi into a standalone platform driver,
> the .init function is called before calling into the stmmac driver
> core, but .exit is not called to clean up if stmmac returns an error.
>
> This patch fixes the probe error path. This properly cleans up and
> releases resources when the driver core fails to probe.
>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Fixes: 9a9e9a1edee8 ("stmmac: dwmac-sunxi: turn setup callback into a
> probe function")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied, thanks.
prev parent reply other threads:[~2015-12-14 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 10:03 [PATCH net] stmmac: dwmac-sunxi: Call exit cleanup function in probe error path Chen-Yu Tsai
2015-12-14 21:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214.161218.2057176608170714361.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).