netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net-next v4 0/4] ila: Optimization to preserve value of early demux
Date: Mon, 14 Dec 2015 16:19:53 -0500 (EST)	[thread overview]
Message-ID: <20151214.161953.1429843640262699390.davem@davemloft.net> (raw)
In-Reply-To: <1449793173-4086221-1-git-send-email-tom@herbertland.com>

From: Tom Herbert <tom@herbertland.com>
Date: Thu, 10 Dec 2015 16:19:29 -0800

> In the current implementation of ILA, LWT is used to perform
> translation on both the input and output paths. This is functional,
> however there is a big performance hit in the receive path. Early
> demux occurs before the routing lookup (a hit actually obviates the
> route lookup). Therefore the stack currently performs early
> demux before translation so that a local connection with ILA
> addresses is never matched. Note that this issue is not just
> with ILA, but pretty much any translated or encapsulated packet
> handled by LWT would miss the opportunity for early demux. Solving
> the general problem seems non trivial since we would need to move
> the route lookup before early demx thereby mitigating the value.
> 
> This patch set addresses the issue for ILA by adding a fast locator
> lookup that occurs before early demux. This done by hooking in to
> NF_INET_PRE_ROUTING
> 
> For the backend we implement an rhashtable that contains identifier
> to locator to mappings. The table also allows more specific matches
> that include original locator and interface.
 ...

Please address Florian's feedback wrt. which nf hook registry interface
should be used, and otherwise I think this series is ready to go.

      parent reply	other threads:[~2015-12-14 21:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11  0:19 [PATCH net-next v4 0/4] ila: Optimization to preserve value of early demux Tom Herbert
2015-12-11  0:19 ` [PATCH net-next v4 1/4] ila: Create net/ipv6/ila directory Tom Herbert
2015-12-11  0:19 ` [PATCH net-next v4 2/4] rhashtable: add function to replace an element Tom Herbert
2015-12-11  0:19 ` [PATCH net-next v4 3/4] netlink: add a start callback for starting a netlink dump Tom Herbert
2015-12-11  0:19 ` [PATCH net-next v4 4/4] ila: Add generic ILA translation facility Tom Herbert
2015-12-11 11:19   ` Florian Westphal
2015-12-18 19:18     ` David Miller
2015-12-14 21:19 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214.161953.1429843640262699390.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).