From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org,
ben.hutchings@codethink.co.uk
Subject: Re: [PATCH] sh_eth: uninline sh_eth_{write|read}()
Date: Mon, 14 Dec 2015 16:25:55 -0500 (EST) [thread overview]
Message-ID: <20151214.162555.1844850396449382434.davem@davemloft.net> (raw)
In-Reply-To: <4404920.p7TanuLbY1@wasted.cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sun, 13 Dec 2015 01:44:50 +0300
> Commit 3365711df024 ("sh_eth: WARN on access to a register not implemented in
> in a particular chip") added WARN_ON() to sh_eth_{read|write}(), thus making
> it unacceptable for these functions to be *inline* anymore. Remove *inline*
> and move the functions from the header to the driver itself. Below is our
> code economy with ARM gcc 4.7.3:
>
> $ size drivers/net/ethernet/renesas/sh_eth.o{~,}
> text data bss dec hex filename
> 32489 1140 0 33629 835d drivers/net/ethernet/renesas/sh_eth.o~
> 25413 1140 0 26553 67b9 drivers/net/ethernet/renesas/sh_eth.o
>
> Suggested-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
prev parent reply other threads:[~2015-12-14 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 22:44 [PATCH] sh_eth: uninline sh_eth_{write|read}() Sergei Shtylyov
2015-12-14 21:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214.162555.1844850396449382434.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben.hutchings@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).