From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: isdn@linux-pingi.de, arnd@arndb.de, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] mISDN: fix a loop count
Date: Tue, 15 Dec 2015 12:51:33 -0500 (EST) [thread overview]
Message-ID: <20151215.125133.1380311053547267182.davem@davemloft.net> (raw)
In-Reply-To: <20151215100752.GC20848@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 15 Dec 2015 13:07:52 +0300
> There are two issue here.
> 1) cnt starts as maxloop + 1 so all these loops iterate one more time
> than intended.
> 2) At the end of the loop we test for "if (maxloop && !cnt)" but for
> the first two loops, we end with cnt equal to -1. Changing this to
> a pre-op means we end with cnt set to 0.
>
> Fixes: cae86d4a4e56 ('mISDN: Add driver for Infineon ISDN chipset family')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
prev parent reply other threads:[~2015-12-15 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 10:07 [patch] mISDN: fix a loop count Dan Carpenter
2015-12-15 17:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215.125133.1380311053547267182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=isdn@linux-pingi.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).