From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net-next 0/8] net: The beginning of the end for NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM
Date: Tue, 15 Dec 2015 16:32:33 -0500 (EST) [thread overview]
Message-ID: <20151215.163233.1822498299187427740.davem@davemloft.net> (raw)
In-Reply-To: <1450120787-1773171-1-git-send-email-tom@herbertland.com>
From: Tom Herbert <tom@herbertland.com>
Date: Mon, 14 Dec 2015 11:19:39 -0800
> This patch set starts to address one front in the battle against
> protocol ossification.
Looks good series applied, thanks.
Two things:
1) I'd ask you to reconsider passing that struct with the bit fields into
the chk routines. Some cpu ABIs pass that thing as an aggregate on
the stack. Whereas if you just use a simple bit mask and BIT(x) values
we know it's always going to be passed in as an integer or whatever.
2) As per the TCP check, it is definitely more strict now. But I seriously
doubt get ever gained anything real with the previous, looser, check.
Besides, if it bites a user segment we will get a report and can adjust
things.
Thanks!
next prev parent reply other threads:[~2015-12-15 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 19:19 [PATCH net-next 0/8] net: The beginning of the end for NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 1/8] net: Add skb_inner_transport_offset function Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 2/8] sctp: Rename NETIF_F_SCTP_CSUM to NETIF_F_SCTP_CRC Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 3/8] fcoe: Use CHECKSUM_PARTIAL to indicate CRC offload Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 4/8] net: Rename NETIF_F_ALL_CSUM to NETIF_F_CSUM_MASK Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 5/8] net: Eliminate NETIF_F_GEN_CSUM and NETIF_F_V[46]_CSUM Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 6/8] tcp: Fix conditions to determine checksum offload Tom Herbert
2015-12-14 19:39 ` Eric Dumazet
2015-12-14 20:39 ` Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 7/8] net: Add driver helper functions to determine checksum offloadability Tom Herbert
2015-12-14 19:19 ` [PATCH net-next 8/8] net: Elaborate on checksum offload interface description Tom Herbert
2015-12-15 21:32 ` David Miller [this message]
2015-12-15 22:11 ` [PATCH net-next 0/8] net: The beginning of the end for NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM Tom Herbert
2015-12-15 22:18 ` Tom Herbert
2015-12-16 2:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215.163233.1822498299187427740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).