From: Florian Westphal <fw@strlen.de>
To: Tom Herbert <tom@herbertland.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v5 net-next 4/4] ila: Add generic ILA translation facility
Date: Tue, 15 Dec 2015 08:06:58 +0100 [thread overview]
Message-ID: <20151215070658.GA16703@breakpoint.cc> (raw)
In-Reply-To: <1450137408-2589240-5-git-send-email-tom@herbertland.com>
Tom Herbert <tom@herbertland.com> wrote:
> +static int ila_add_mapping(struct net *net, struct ila_xlat_params *p)
> +{
> + struct ila_net *ilan = net_generic(net, ila_net_id);
> + struct ila_map *ila, *head;
> + spinlock_t *lock = ila_get_lock(ilan, p->identifier);
> + int err = 0, order;
> +
> + if (!ilan->hooks_registered) {
> + /* We defer registering net hooks in the namespace until the
> + * first mapping is added.
> + */
> + err = nf_register_net_hooks(net, ila_nf_hook_ops,
> + ARRAY_SIZE(ila_nf_hook_ops));
> + if (err)
> + return err;
Looks as if this misses a
ilan->hooks_registered = true
> + }
> +
> + ila = kzalloc(sizeof(*ila), GFP_KERNEL);
prev parent reply other threads:[~2015-12-15 7:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 23:56 [PATCH v5 net-next 0/4] ila: Optimization to preserve value of early demux Tom Herbert
2015-12-14 23:56 ` [PATCH v5 net-next 1/4] ila: Create net/ipv6/ila directory Tom Herbert
2015-12-14 23:56 ` [PATCH v5 net-next 2/4] rhashtable: add function to replace an element Tom Herbert
2015-12-14 23:56 ` [PATCH v5 net-next 3/4] netlink: add a start callback for starting a netlink dump Tom Herbert
2015-12-14 23:56 ` [PATCH v5 net-next 4/4] ila: Add generic ILA translation facility Tom Herbert
2015-12-15 4:50 ` David Miller
2015-12-15 7:06 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215070658.GA16703@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).