netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ipv6: allow setting stable_secret mode
Date: Wed, 16 Dec 2015 10:56:20 -0800	[thread overview]
Message-ID: <20151216105620.331d28ab@xeon-e3> (raw)
In-Reply-To: <1450265408-20510-1-git-send-email-hannes@stressinduktion.org>

On Wed, 16 Dec 2015 12:30:08 +0100
Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:

> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
>  ip/iplink.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ip/iplink.c b/ip/iplink.c
> index f30de86d1858a0..e824082f7d8149 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -84,7 +84,7 @@ void iplink_usage(void)
>  	fprintf(stderr, "				   [ state { auto | enable | disable} ] ]\n");
>  	fprintf(stderr, "			  [ master DEVICE ]\n");
>  	fprintf(stderr, "			  [ nomaster ]\n");
> -	fprintf(stderr, "			  [ addrgenmode { eui64 | none } ]\n");
> +	fprintf(stderr, "			  [ addrgenmode { eui64 | none | stable_secret } ]\n");
>  	fprintf(stderr, "	                  [ protodown { on | off } ]\n");
>  	fprintf(stderr, "       ip link show [ DEVICE | group GROUP ] [up] [master DEV] [type TYPE]\n");
>  
> @@ -176,6 +176,8 @@ static int get_addr_gen_mode(const char *mode)
>  		return IN6_ADDR_GEN_MODE_EUI64;
>  	if (strcasecmp(mode, "none") == 0)
>  		return IN6_ADDR_GEN_MODE_NONE;
> +	if (strcasecmp(mode, "stable_secret") == 0)
> +		return IN6_ADDR_GEN_MODE_STABLE_PRIVACY;
>  	return -1;
>  }
>  

ip options are supposed to be clse to invertable. ie what is displayed on show
command should match what are options for set.  There were even some VPN scripts
that depended on this.

      parent reply	other threads:[~2015-12-16 18:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 11:30 [PATCH iproute2] ipv6: allow setting stable_secret mode Hannes Frederic Sowa
2015-12-16 16:56 ` Bjørn Mork
2015-12-16 17:04   ` Hannes Frederic Sowa
2015-12-16 18:56 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151216105620.331d28ab@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).