netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2 -next] bpf: minor fix in api and bpf_dump_error() usage
@ 2015-12-14 15:57 Daniel Borkmann
  2015-12-18  1:23 ` Stephen Hemminger
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Borkmann @ 2015-12-14 15:57 UTC (permalink / raw)
  To: stephen; +Cc: ast, netdev, Daniel Borkmann

Fix a whitespace in bpf_dump_error() usage, and also a missing closing
bracket in ntohl() macro for eBPF programs.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
 include/bpf_api.h | 2 +-
 tc/tc_bpf.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/bpf_api.h b/include/bpf_api.h
index 8503b9a..0666a31 100644
--- a/include/bpf_api.h
+++ b/include/bpf_api.h
@@ -53,7 +53,7 @@
 #endif
 
 #ifndef ntohl
-# define ntohl(X)		__constant_ntohl((X)
+# define ntohl(X)		__constant_ntohl((X))
 #endif
 
 /** Section helper macros. */
diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c
index beb74be..f9b2b00 100644
--- a/tc/tc_bpf.c
+++ b/tc/tc_bpf.c
@@ -1042,7 +1042,7 @@ static int bpf_prog_attach(const char *section,
 			       "license:\'%s\') %s%s (%d)!\n\n",
 			       section, prog->type,
 			       prog->size / sizeof(struct bpf_insn),
-			       prog->license, fd < 0 ? "rejected :" :
+			       prog->license, fd < 0 ? "rejected: " :
 			       "loaded", fd < 0 ? strerror(errno) : "",
 			       fd < 0 ? errno : fd);
 	}
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2 -next] bpf: minor fix in api and bpf_dump_error() usage
  2015-12-14 15:57 [PATCH iproute2 -next] bpf: minor fix in api and bpf_dump_error() usage Daniel Borkmann
@ 2015-12-18  1:23 ` Stephen Hemminger
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2015-12-18  1:23 UTC (permalink / raw)
  To: Daniel Borkmann; +Cc: ast, netdev

On Mon, 14 Dec 2015 16:57:32 +0100
Daniel Borkmann <daniel@iogearbox.net> wrote:

> Fix a whitespace in bpf_dump_error() usage, and also a missing closing
> bracket in ntohl() macro for eBPF programs.
> 
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---

Applied to net-next

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-18  1:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14 15:57 [PATCH iproute2 -next] bpf: minor fix in api and bpf_dump_error() usage Daniel Borkmann
2015-12-18  1:23 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).