From: Stephen Hemminger <stephen@networkplumber.org>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>,
Ivan Vecera <ivecera@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linuxbrad@gmail.com
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next] asix: silence log message from oversize packet
Date: Thu, 17 Dec 2015 17:51:16 -0800 [thread overview]
Message-ID: <20151217175116.234fa63b@xeon-e3> (raw)
Since it is possible for an external system to send oversize packets
at anytime, it is best for driver not to print a message and spam
the log (potential external DoS).
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=109471
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/drivers/net/usb/asix_common.c 2015-10-16 16:05:30.997785598 -0700
+++ b/drivers/net/usb/asix_common.c 2015-12-17 17:50:30.983973764 -0800
@@ -118,7 +118,7 @@ int asix_rx_fixup_internal(struct usbnet
return 0;
}
if (size > dev->net->mtu + ETH_HLEN + VLAN_HLEN) {
- netdev_err(dev->net, "asix_rx_fixup() Bad RX Length %d\n",
+ netdev_dbg(dev->net, "asix_rx_fixup() Bad RX Length %d\n",
size);
return 0;
}
next reply other threads:[~2015-12-18 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 1:51 Stephen Hemminger [this message]
2015-12-18 21:08 ` [PATCH net-next] asix: silence log message from oversize packet David Miller
2015-12-19 0:15 ` Stephen Hemminger
2015-12-19 2:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217175116.234fa63b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=linuxbrad@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).