* [PATCH net-next] nfp: call netif_carrier_off() during init
@ 2015-12-17 14:18 Jakub Kicinski
2015-12-18 20:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2015-12-17 14:18 UTC (permalink / raw)
To: netdev; +Cc: simon.horman, rolf.neugebauer, Jakub Kicinski
Netdevs default to carrier on, we should call netif_carrier_off()
during initialization since we handle carrier state changes in the
driver.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Rolf Neugebauer <rolf.neugebauer@netronome.com>
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 6c5af4cb5bdc..43c618bafdb6 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -2417,6 +2417,7 @@ int nfp_net_netdev_init(struct net_device *netdev)
ether_setup(netdev);
netdev->netdev_ops = &nfp_net_netdev_ops;
netdev->watchdog_timeo = msecs_to_jiffies(5 * 1000);
+ netif_carrier_off(netdev);
nfp_net_set_ethtool_ops(netdev);
nfp_net_irqs_assign(netdev);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] nfp: call netif_carrier_off() during init
2015-12-17 14:18 [PATCH net-next] nfp: call netif_carrier_off() during init Jakub Kicinski
@ 2015-12-18 20:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-12-18 20:31 UTC (permalink / raw)
To: jakub.kicinski; +Cc: netdev, simon.horman, rolf.neugebauer
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 17 Dec 2015 14:18:44 +0000
> Netdevs default to carrier on, we should call netif_carrier_off()
> during initialization since we handle carrier state changes in the
> driver.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Rolf Neugebauer <rolf.neugebauer@netronome.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-18 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-17 14:18 [PATCH net-next] nfp: call netif_carrier_off() during init Jakub Kicinski
2015-12-18 20:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).