From: David Miller <davem@davemloft.net>
To: venkatkumar.duvvuru@avagotech.com
Cc: netdev@vger.kernel.org, venkatkumar.duvvuru@vger.kernel.org
Subject: Re: [PATCH net] be2net: Avoid accessing eq object in be_msix_register routine, when i < 0.
Date: Fri, 18 Dec 2015 15:51:18 -0500 (EST) [thread overview]
Message-ID: <20151218.155118.779504200158181032.davem@davemloft.net> (raw)
In-Reply-To: <1450383050-25106-1-git-send-email-venkatkumar.duvvuru@avagotech.com>
From: Venkat Duvvuru <venkatkumar.duvvuru@avagotech.com>
Date: Fri, 18 Dec 2015 01:40:50 +0530
> When the first request_irq fails in be_msix_register, i value
> would be zero. The current code decrements the i value and
> accesses the eq object without validating the decremented
> "i" value. This can cause an "invalid memory address access"
> violation.
>
> This patch fixes the problem by accessing the eq object after
> validating the "i" value.
>
> Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@avagotech.com>
Applied, thank you.
prev parent reply other threads:[~2015-12-18 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 20:10 [PATCH net] be2net: Avoid accessing eq object in be_msix_register routine, when i < 0 Venkat Duvvuru
2015-12-18 20:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218.155118.779504200158181032.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=venkatkumar.duvvuru@avagotech.com \
--cc=venkatkumar.duvvuru@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).