Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.

Stephen Hemminger
2015-12-22T05:42:15Z

On Thu, 17 Dec 2015 22:22:18 +0900
Lorenzo Colitti <lorenzo@google.com> wrote:

> diff --git a/misc/ss.c b/misc/ss.c
> index 0dab32c..be70c41 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -160,6 +160,9 @@ struct filter
> int states;
> int families;
> struct ssfilter *f;
> + struct {
> + __u8 kill:1;
> + } action;
> };
>
> stati

Please just make it a boolean or integer, not a structure wrapped around a bit field.
If you need to extend in the future then change it then. Please don't write code
based on speculative future additions.