From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support Date: Tue, 22 Dec 2015 18:01:54 +0100 Message-ID: <20151222170154.GA1940@localhost.localdomain> References: <1450647991-13736-1-git-send-email-saeedm@mellanox.com> <1450647991-13736-4-git-send-email-saeedm@mellanox.com> <20151221091509.GA2297@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Saeed Mahameed , "David S. Miller" , netdev@vger.kernel.org, Or Gerlitz , Eran Ben Elisha , Tal Alon , Majd Dibbiny , Achiad Shochat To: Saeed Mahameed Return-path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:33710 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754249AbbLVRB7 (ORCPT ); Tue, 22 Dec 2015 12:01:59 -0500 Received: by mail-wm0-f54.google.com with SMTP id p187so115906516wmp.0 for ; Tue, 22 Dec 2015 09:01:58 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Dec 22, 2015 at 12:00:52PM +0200, Saeed Mahameed wrote: > Ok, but what will happen if somehow tstamp->overflow_period is zero ? > the work will run too rapidly. > don't we need to have protection against such case. Why not return an error in that case? Thanks, Richard