From: Hariprasad Shenai <hariprasad@chelsio.com>
To: David Miller <davem@davemloft.net>
Cc: gerlitz.or@gmail.com, netdev@vger.kernel.org, leedom@chelsio.com,
nirranjan@chelsio.com, john.r.fastabend@intel.com
Subject: Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs
Date: Wed, 23 Dec 2015 10:37:52 +0530 [thread overview]
Message-ID: <20151223050750.GA23659@hari-Latitude-E5550> (raw)
In-Reply-To: <20151222.154552.1762036210080562354.davem@davemloft.net>
On Tue, Dec 22, 2015 at 15:45:52 -0500, David Miller wrote:
> From: Or Gerlitz <gerlitz.or@gmail.com>
> Date: Mon, 21 Dec 2015 09:33:22 +0200
>
> > On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai
> > <hariprasad@chelsio.com> wrote:
> >> Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out
> >> various Data Center Bridging information.
> >
> > why? what's wrong with using the lldp tool for that purpose?
>
> Agreed, and I don't like your explanation.
>
> Even if you are using firmware managed DCB, the lldp tool should be
> usable for querying.
>
> People need to stop putting so much crap into debugfs, it's a serious
> pet peeve of mine.
>
> Every piece of driver unique interface crap you put into debugfs is a
> _HARDSHIP_ for the user. Because they have to learn a unique way to
> do X in every driver that tries to export the same kind of
> functionality.
Will drop this from the series for now and send V2 for the same.
Will send a separate series for adding lldptool support for firmware
managed DCB.
next prev parent reply other threads:[~2015-12-23 5:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 7:16 [PATCH net-next 0/5] Trivial enhancements for cxgb4 Hariprasad Shenai
2015-12-21 7:16 ` [PATCH net-next 1/5] cxgb4: Warn if device doesn't have enough PCI bandwidth Hariprasad Shenai
2015-12-21 7:16 ` [PATCH net-next 2/5] cxgb4: get naming correct for iscsi queues Hariprasad Shenai
2015-12-21 7:16 ` [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs Hariprasad Shenai
2015-12-21 7:33 ` Or Gerlitz
2015-12-22 11:41 ` Hariprasad S
2015-12-22 20:45 ` David Miller
2015-12-23 5:07 ` Hariprasad Shenai [this message]
2015-12-21 7:16 ` [PATCH net-next 4/5] cxgb4: Use the node info to alloc_ring() for RX queues Hariprasad Shenai
2015-12-21 7:16 ` [PATCH net-next 5/5] cxgb4: Use napi_complete_done() api in napi handler Hariprasad Shenai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223050750.GA23659@hari-Latitude-E5550 \
--to=hariprasad@chelsio.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox