From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats
Date: Sun, 27 Dec 2015 21:12:23 +0100 [thread overview]
Message-ID: <20151227201223.GA24712@lunn.ch> (raw)
In-Reply-To: <EEE79716-61A1-403E-826D-198C21667070@gmail.com>
On Sun, Dec 27, 2015 at 12:07:15PM -0800, Florian Fainelli wrote:
> On December 27, 2015 3:58:25 AM PST, Andrew Lunn <andrew@lunn.ch> wrote:
> >This patchset add ethtool support for reading statistics from the PHY.
> >The Marvell and Micrel Phys are then extended to report receiver
> >packet errors and idle errors.
>
> Reviewed-by: Florian Fainelli <f.faibelli@gmail.com>
>
> This is very useful, thanks! I like that you have introduced a
> separate interface rather than forcing the use of the existing get
> statistics method and then overlaying PHY stats to the existing MAC
> stats, this is just cleaner.
I started out by extending the MAC stats, but the code was ugly
dealing with the different cases and MAC and PHY statistics. This way
is a lot cleaner.
Andrew
next prev parent reply other threads:[~2015-12-27 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 11:58 [PATCHv2 net-next 0/3] Ethtool support for phy stats Andrew Lunn
2015-12-27 11:58 ` [PATCHv2 net-next 1/3] ethtool: Add phy statistics Andrew Lunn
2015-12-27 11:58 ` [PATCHv2 net-next 2/3] phy: marvell: Add ethtool statistics counters Andrew Lunn
2015-12-27 11:58 ` [PATCHv2 net-next 3/3] phy: micrel: " Andrew Lunn
2015-12-27 20:07 ` [PATCHv2 net-next 0/3] Ethtool support for phy stats Florian Fainelli
2015-12-27 20:12 ` Andrew Lunn [this message]
2015-12-28 5:32 ` David Miller
2015-12-28 5:44 ` David Miller
2015-12-28 8:58 ` Andrew Lunn
2015-12-28 17:27 ` Florian Fainelli
2015-12-28 20:02 ` David Miller
2015-12-28 20:28 ` Florian Fainelli
2015-12-28 17:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151227201223.GA24712@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).