From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats
Date: Mon, 28 Dec 2015 09:58:25 +0100 [thread overview]
Message-ID: <20151228085825.GA30297@lunn.ch> (raw)
In-Reply-To: <20151228.004427.1444978630699405304.davem@davemloft.net>
On Mon, Dec 28, 2015 at 12:44:27AM -0500, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 28 Dec 2015 00:32:43 -0500 (EST)
>
> > From: Andrew Lunn <andrew@lunn.ch>
> > Date: Sun, 27 Dec 2015 12:58:25 +0100
> >
> >> This patchset add ethtool support for reading statistics from the PHY.
> >> The Marvell and Micrel Phys are then extended to report receiver
> >> packet errors and idle errors.
> >>
> >> v2:
> >> Fix linking when phylib is not enabled.
> >
> > Series applied, thanks Andrew.
>
> I have to revert this.
>
> You can't call into PHY library code from net/core/ethtool.c,
> because PHY lib can be modular.
O.K.
How about we change PHYLIB from a tristate to a bool?
Thanks
Andrew
next prev parent reply other threads:[~2015-12-28 8:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 11:58 [PATCHv2 net-next 0/3] Ethtool support for phy stats Andrew Lunn
2015-12-27 11:58 ` [PATCHv2 net-next 1/3] ethtool: Add phy statistics Andrew Lunn
2015-12-27 11:58 ` [PATCHv2 net-next 2/3] phy: marvell: Add ethtool statistics counters Andrew Lunn
2015-12-27 11:58 ` [PATCHv2 net-next 3/3] phy: micrel: " Andrew Lunn
2015-12-27 20:07 ` [PATCHv2 net-next 0/3] Ethtool support for phy stats Florian Fainelli
2015-12-27 20:12 ` Andrew Lunn
2015-12-28 5:32 ` David Miller
2015-12-28 5:44 ` David Miller
2015-12-28 8:58 ` Andrew Lunn [this message]
2015-12-28 17:27 ` Florian Fainelli
2015-12-28 20:02 ` David Miller
2015-12-28 20:28 ` Florian Fainelli
2015-12-28 17:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228085825.GA30297@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).