netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCHv3 net-next 1/3] ethtool: Add phy statistics
Date: Tue, 29 Dec 2015 15:12:02 -0500 (EST)	[thread overview]
Message-ID: <20151229.151202.766585486801107901.davem@davemloft.net> (raw)
In-Reply-To: <1451418684-9238-2-git-send-email-andrew@lunn.ch>

From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 29 Dec 2015 20:51:22 +0100

> @@ -191,6 +191,23 @@ static int ethtool_set_features(struct net_device *dev, void __user *useraddr)
>  	return ret;
>  }
>  
> +int phy_get_sset_count(struct phy_device *phydev)
> +{

This needs to be static.

  reply	other threads:[~2015-12-29 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29 19:51 [PATCHv3 net-next 0/3] Ethtool support for phy stats Andrew Lunn
2015-12-29 19:51 ` [PATCHv3 net-next 1/3] ethtool: Add phy statistics Andrew Lunn
2015-12-29 20:12   ` David Miller [this message]
2015-12-29 19:51 ` [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters Andrew Lunn
2015-12-30  4:24   ` Shaohui Xie
2015-12-30 15:12     ` Andrew Lunn
2015-12-31  5:24       ` Shaohui Xie
2015-12-29 19:51 ` [PATCHv3 net-next 3/3] phy: micrel: " Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229.151202.766585486801107901.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).