From: David Miller <davem@davemloft.net>
To: tom.leiming@gmail.com
Cc: linux-kernel@vger.kernel.org, ast@kernel.org,
netdev@vger.kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH v2 0/3] bpf: hash: use per-bucket spinlock
Date: Tue, 29 Dec 2015 15:14:05 -0500 (EST) [thread overview]
Message-ID: <20151229.151405.518049202533460569.davem@davemloft.net> (raw)
In-Reply-To: <1451400027-28892-1-git-send-email-tom.leiming@gmail.com>
From: Ming Lei <tom.leiming@gmail.com>
Date: Tue, 29 Dec 2015 22:40:24 +0800
> Hi,
>
> This patchset tries to optimize ebpf hash map, and follows
> the idea:
>
> Both htab_map_update_elem() and htab_map_delete_elem()
> can be called from eBPF program, and they may be in kernel
> hot path, it isn't efficient to use a per-hashtable lock
> in this two helpers, so this patch converts the lock into
> per-bucket spinlock.
>
> With this patchset, looks the performance penalty from eBPF
> decreased a lot, see the following test:
>
> 1) run 'tools/biolatency' of bcc before running block test;
>
> 2) run fio to test block throught over /dev/nullb0,
> (randread, 16jobs, libaio, 4k bs) and the test box
> is one 24cores(dual sockets) VM server:
> - without patchset: 607K IOPS
> - with this patchset: 1184K IOPS
> - without running eBPF prog: 1492K IOPS
Series applied, thanks.
prev parent reply other threads:[~2015-12-29 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 14:40 [PATCH v2 0/3] bpf: hash: use per-bucket spinlock Ming Lei
2015-12-29 14:40 ` [PATCH v2 1/3] bpf: hash: use atomic count Ming Lei
2015-12-29 14:40 ` [PATCH v2 2/3] bpf: hash: move select_bucket() out of htab's spinlock Ming Lei
2015-12-29 14:40 ` [PATCH v2 3/3] bpf: hash: use per-bucket spinlock Ming Lei
2015-12-29 16:27 ` Daniel Borkmann
2015-12-29 20:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151229.151405.518049202533460569.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).