From: Stephen Hemminger <stephen@networkplumber.org>
To: Andreas Henriksson <andreas@fatal.se>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long comments
Date: Sun, 3 Jan 2016 15:04:25 -0800 [thread overview]
Message-ID: <20160103150425.79f05a52@xeon-e3> (raw)
In-Reply-To: <20160103184429.GA2713@fatal.se>
On Sun, 3 Jan 2016 19:44:29 +0100
Andreas Henriksson <andreas@fatal.se> wrote:
> Hello Stephen Hemminger.
>
> Please beware that this has been compile-tested only.
> Submitting it like this was what I was trying to avoid
> by just throwing in a FIXME comment in the initial submission.
> Sorry in advance if I managed to screw something up, but
> hopefully I didn't...
>
> Regards,
> Andreas Henriksson
>
All this seems like overkill. The file format for arpd is very simple:
ifindex, IPv4, MAC
and really should never be too long. If it is the input is garbage and the
whole input should just be rejected, logged, and arpd should exit.
prev parent reply other threads:[~2016-01-03 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 16:09 [PATCH iproute2] arpd: drop unnecessary explicit null termination Andreas Henriksson
2016-01-03 17:04 ` Stephen Hemminger
2016-01-03 18:39 ` [PATCH iproute2 v2 1/2] " Andreas Henriksson
2016-01-03 18:39 ` [PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long comments Andreas Henriksson
2016-01-03 18:44 ` Andreas Henriksson
2016-01-03 23:04 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160103150425.79f05a52@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=andreas@fatal.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).