From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: dvyukov@google.com, herbert@gondor.apana.org.au, tgraf@suug.ch,
daniel@iogearbox.net, chamaken@gmail.com,
nicolas.dichtel@6wind.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller@googlegroups.com,
kcc@google.com, glider@google.com, sasha.levin@oracle.com,
edumazet@google.com, zbr@ioremap.net
Subject: Re: [PATCH] connector: bump skb->users before callback invocation
Date: Mon, 04 Jan 2016 21:47:33 -0500 (EST) [thread overview]
Message-ID: <20160104.214733.921867451376206917.davem@davemloft.net> (raw)
In-Reply-To: <20151231132633.GA30790@breakpoint.cc>
From: Florian Westphal <fw@strlen.de>
Date: Thu, 31 Dec 2015 14:26:33 +0100
> Dmitry reports memleak with syskaller program.
> Problem is that connector bumps skb usecount but might not invoke callback.
>
> So move skb_get to where we invoke the callback.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2016-01-05 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 11:51 net/netlink: memory leak in netlink_sendmsg Dmitry Vyukov
2015-12-31 13:26 ` [PATCH] connector: bump skb->users before callback invocation Florian Westphal
2016-01-05 2:47 ` David Miller [this message]
2016-01-11 20:03 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104.214733.921867451376206917.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chamaken@gmail.com \
--cc=daniel@iogearbox.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=glider@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=tgraf@suug.ch \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).