From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] connector: bump skb->users before callback invocation Date: Mon, 04 Jan 2016 21:47:33 -0500 (EST) Message-ID: <20160104.214733.921867451376206917.davem@davemloft.net> References: <20151231132633.GA30790@breakpoint.cc> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dvyukov@google.com, herbert@gondor.apana.org.au, tgraf@suug.ch, daniel@iogearbox.net, chamaken@gmail.com, nicolas.dichtel@6wind.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com, kcc@google.com, glider@google.com, sasha.levin@oracle.com, edumazet@google.com, zbr@ioremap.net To: fw@strlen.de Return-path: In-Reply-To: <20151231132633.GA30790@breakpoint.cc> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Florian Westphal Date: Thu, 31 Dec 2015 14:26:33 +0100 > Dmitry reports memleak with syskaller program. > Problem is that connector bumps skb usecount but might not invoke callback. > > So move skb_get to where we invoke the callback. > > Reported-by: Dmitry Vyukov > Signed-off-by: Florian Westphal Applied and queued up for -stable, thanks.