From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: Propagate lookup failure in l3mdev_get_saddr to caller
Date: Mon, 04 Jan 2016 22:58:54 -0500 (EST) [thread overview]
Message-ID: <20160104.225854.1644508041816573984.davem@davemloft.net> (raw)
In-Reply-To: <1451927367-14527-1-git-send-email-dsa@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Mon, 4 Jan 2016 09:09:27 -0800
> Commands run in a vrf context are not failing as expected on a route lookup:
> root@kenny:~# ip ro ls table vrf-red
> unreachable default
>
> root@kenny:~# ping -I vrf-red -c1 -w1 10.100.1.254
> ping: Warning: source address might be selected on device other than vrf-red.
> PING 10.100.1.254 (10.100.1.254) from 0.0.0.0 vrf-red: 56(84) bytes of data.
>
> --- 10.100.1.254 ping statistics ---
> 2 packets transmitted, 0 received, 100% packet loss, time 999ms
>
> Since the vrf table does not have a route for 10.100.1.254 the ping
> should have failed. The saddr lookup causes a full VRF table lookup.
> Propogating a lookup failure to the user allows the command to fail as
> expected:
>
> root@kenny:~# ping -I vrf-red -c1 -w1 10.100.1.254
> connect: No route to host
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied, thanks David.
prev parent reply other threads:[~2016-01-05 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 17:09 [PATCH net] net: Propagate lookup failure in l3mdev_get_saddr to caller David Ahern
2016-01-05 3:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104.225854.1644508041816573984.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).