From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: pshelar@nicira.com, netdev@vger.kernel.org,
willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull
Date: Mon, 04 Jan 2016 23:08:04 -0500 (EST) [thread overview]
Message-ID: <20160104.230804.2220774053197810472.davem@davemloft.net> (raw)
In-Reply-To: <1451498745.8255.35.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 30 Dec 2015 13:05:45 -0500
> On Thu, 2015-09-24 at 14:09 -0700, David Miller wrote:
>> From: Pravin B Shelar <pshelar@nicira.com>
>> Date: Tue, 22 Sep 2015 12:57:53 -0700
>>
>> > VXLAN device can receive skb with checksum partial. But the checksum
>> > offset could be in outer header which is pulled on receive. This results
>> > in negative checksum offset for the skb. Such skb can cause the assert
>> > failure in skb_checksum_help(). Following patch fixes the bug by setting
>> > checksum-none while pulling outer header.
>> >
>> > Following is the kernel panic msg from old kernel hitting the bug.
>> ...
>> > Reported-by: Anupam Chanda <achanda@vmware.com>
>> > Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
>>
>> Applied, thanks.
>
>
> It looks like we also should clear skb->csum ?
>
> __skb_checksum_complete() definitely would be confused by garbage in
> skb->csum
Pravin, please take a look at this.
next prev parent reply other threads:[~2016-01-05 4:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 19:57 [PATCH net v2] skbuff: Fix skb checksum flag on skb pull Pravin B Shelar
2015-09-22 21:28 ` Tom Herbert
2015-09-24 21:09 ` David Miller
2015-09-26 2:48 ` Pravin Shelar
2015-09-29 5:32 ` David Miller
2015-12-30 18:05 ` Eric Dumazet
2016-01-05 4:08 ` David Miller [this message]
2016-01-05 6:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104.230804.2220774053197810472.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).