From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org, dledford@redhat.com,
ogerlitz@mellanox.com, eranbe@mellanox.com, talal@mellanox.com,
majd@mellanox.com, matanb@mellanox.com, maorg@mellanox.com,
monis@mellanox.com, saeedm@dev.mellanox.co.il
Subject: Re: [PATCH net-next 01/12] net/mlx5_core: Introduce flow steering autogrouped flow table
Date: Tue, 05 Jan 2016 23:58:25 -0500 (EST) [thread overview]
Message-ID: <20160105.235825.203310986288483393.davem@davemloft.net> (raw)
In-Reply-To: <1452024253-21193-2-git-send-email-saeedm@mellanox.com>
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Tue, 5 Jan 2016 22:04:02 +0200
> - /* Add node to tree */
> - tree_init_node(&fg->node, 1, del_flow_group);
Why in the world would you take a properly formatted comment:
> + /*Add node to tree*/
And proceed to molest it like this?
Please don't do this.
next prev parent reply other threads:[~2016-01-06 4:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 20:04 [PATCH net-next 00/12] net/mlx5_core: Enhance flow steering support Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 01/12] net/mlx5_core: Introduce flow steering autogrouped flow table Saeed Mahameed
2016-01-06 4:58 ` David Miller [this message]
2016-01-05 20:04 ` [PATCH net-next 02/12] net/mlx5_core: Add utilities to find next and prev flow-tables Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 03/12] net/mlx5_core: Managing root flow table Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 04/12] net/mlx5_core: Introduce modify flow table command Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 05/12] net/mlx5_core: Connect flow tables Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 06/12] net/mlx5_core: Set priority attributes Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 07/12] net/mlx5_core: Initialize namespaces only when supported by device Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 08/12] net/mlx5_core: Enable flow steering support for the IB driver Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 09/12] net/mlx5_core: Make ipv4/ipv6 location more clear Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 10/12] net/mlx5_core: Export flow steering API Saeed Mahameed
2016-01-05 20:04 ` [PATCH net-next 11/12] IB/mlx5: Add flow steering utilities Saeed Mahameed
2016-01-06 8:02 ` Or Gerlitz
2016-01-05 20:04 ` [PATCH net-next 12/12] IB/mlx5: Add flow steering support Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105.235825.203310986288483393.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=eranbe@mellanox.com \
--cc=majd@mellanox.com \
--cc=maorg@mellanox.com \
--cc=matanb@mellanox.com \
--cc=monis@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).