From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: sched: fix missing free per cpu on qstats Date: Wed, 06 Jan 2016 01:41:21 -0500 (EST) Message-ID: <20160106.014121.2086606632987547429.davem@davemloft.net> References: <1452015851.8255.108.camel@edumazet-glaptop2.roam.corp.google.com> <1452049669.8255.157.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: xiyou.wangcong@gmail.com, john.fastabend@gmail.com, netdev@vger.kernel.org, daniel@iogearbox.net To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:34126 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbcAFGlY (ORCPT ); Wed, 6 Jan 2016 01:41:24 -0500 In-Reply-To: <1452049669.8255.157.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Tue, 05 Jan 2016 19:07:49 -0800 > On Tue, 2016-01-05 at 18:49 -0800, Cong Wang wrote: >> On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet wrote: >> > On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote: >> >> When a qdisc is using per cpu stats (currently just the ingress >> >> qdisc) only the bstats are being freed. This also free's the qstats. >> >> >> >> Signed-off-by: John Fastabend >> >> --- >> > >> > Acked-by: Eric Dumazet >> > >> > David, please add the following tag to ease backports to stable kernels: >> > >> > Fixes: 22e0f8b9322cb ("net: sched: make bstats per cpu and estimator RCU safe") >> > >> >> Not a big deal at all but... doesn't that fix commit b0ab6f92752b9f9d8 >> instead of 22e0f8b9322cb? > > Hmmm... you may be right. Both were added in 3.18. > > My search was based on commit adding qdisc_is_percpu_stats() The right commit looks to be b0ab6f92752b9f9d8, so that's what I've used in the Fixes: tag. Applied and queued up for -stable, thanks!