* [PATCH net-next] ixgbe: Fix for RAR0 not being set to default MAC addr
@ 2016-01-06 20:05 Tushar Dave
2016-01-06 20:48 ` Sowmini Varadhan
0 siblings, 1 reply; 2+ messages in thread
From: Tushar Dave @ 2016-01-06 20:05 UTC (permalink / raw)
To: jesse.brandeburg, john.ronciak, donald.c.skidmore,
carolyn.wyborny, netdev, duyck
Cc: davem, Tushar Dave
commit c9f53e63c208 ("ixgbe: Refactor MAC address configuration code")
introduced code that doesn't set HW register RAR0 to default mac address
but FF:FF:FF:FF:FF:FF. Due to this, ixgbe HW discards all incoming packets
that doesn't have destination mac address equals to FF:FF:FF:FF:FF:FF.
This commit sets RAR0 correctly to default HW mac address.
Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index ea9537d..7e6ce13 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -9084,6 +9084,8 @@ skip_sriov:
goto err_sw_init;
}
+ /* Set hw->addr to permanent mac address*/
+ ether_addr_copy(hw->mac.addr, hw->mac.perm_addr);
ixgbe_mac_set_default_filter(adapter);
setup_timer(&adapter->service_timer, &ixgbe_service_timer,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ixgbe: Fix for RAR0 not being set to default MAC addr
2016-01-06 20:05 [PATCH net-next] ixgbe: Fix for RAR0 not being set to default MAC addr Tushar Dave
@ 2016-01-06 20:48 ` Sowmini Varadhan
0 siblings, 0 replies; 2+ messages in thread
From: Sowmini Varadhan @ 2016-01-06 20:48 UTC (permalink / raw)
To: Tushar Dave
Cc: jesse.brandeburg, john.ronciak, donald.c.skidmore,
carolyn.wyborny, netdev, duyck, davem, jeffrey.t.kirsher,
intel-wired-lan
On (01/06/16 12:05), Tushar Dave wrote:
> commit c9f53e63c208 ("ixgbe: Refactor MAC address configuration code")
> introduced code that doesn't set HW register RAR0 to default mac address
> but FF:FF:FF:FF:FF:FF. Due to this, ixgbe HW discards all incoming packets
> that doesn't have destination mac address equals to FF:FF:FF:FF:FF:FF.
>
> This commit sets RAR0 correctly to default HW mac address.
>
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
Tested-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-06 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-06 20:05 [PATCH net-next] ixgbe: Fix for RAR0 not being set to default MAC addr Tushar Dave
2016-01-06 20:48 ` Sowmini Varadhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).