From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH] net: lpc_eth: Remove unused variables
Date: Fri, 8 Jan 2016 16:58:32 +0100 [thread overview]
Message-ID: <20160108155832.GH4389@lunn.ch> (raw)
In-Reply-To: <1452255556-21827-1-git-send-email-festevam@gmail.com>
On Fri, Jan 08, 2016 at 10:19:16AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> introduced the following build warnings:
>
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_mii_init':
> drivers/net/ethernet/nxp/lpc_eth.c:865:1: warning: label 'err_out_1' defined but not used [-Wunused-label]
> drivers/net/ethernet/nxp/lpc_eth.c:826:20: warning: unused variable 'i' [-Wunused-variable]
>
> Remove the unused variables to fix them.
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> drivers/net/ethernet/nxp/lpc_eth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index a9ce37f..b1ce7aa 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -823,7 +823,7 @@ static int lpc_mii_probe(struct net_device *ndev)
>
> static int lpc_mii_init(struct netdata_local *pldat)
> {
> - int err = -ENXIO, i;
> + int err = -ENXIO;
>
> pldat->mii_bus = mdiobus_alloc();
> if (!pldat->mii_bus) {
> @@ -862,7 +862,6 @@ static int lpc_mii_init(struct netdata_local *pldat)
>
> err_out_unregister_bus:
> mdiobus_unregister(pldat->mii_bus);
> -err_out_1:
> mdiobus_free(pldat->mii_bus);
> err_out:
> return err;
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-01-08 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 12:19 [PATCH] net: lpc_eth: Remove unused variables Fabio Estevam
2016-01-08 15:58 ` Andrew Lunn [this message]
2016-01-11 3:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108155832.GH4389@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).