From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Woojung.Huh@microchip.com, netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: phy: Support for non-HW interrupt devices
Date: Fri, 8 Jan 2016 22:36:40 +0100 [thread overview]
Message-ID: <20160108213640.GA28440@lunn.ch> (raw)
In-Reply-To: <56901B96.8020606@gmail.com>
> Sounds good, I will send some patches shortly which really fix the PHY
> state machine not to poll PHYs configured with PHY_IGNORE_INTERRUPT and
> fixing phy_mac_interrupt() to be callable in hard IRQ context (finally).
This last be could be interesting. One of the things i needed to do
was change request_irq to request_threaded_irq(). Because i need to do
MDIO reads to determine what PHY causes the interrupts, the code is in
thread context when it actually fires the interrupt.
The core IRQ code is happy to turn an interrupt context interrupt into
a threaded context interrupt, but it cannot do it the other way
around.
Using threaded interrupts would also allow the phylib code to be
simplified, but i didn't get that far yet.
Andrew
prev parent reply other threads:[~2016-01-08 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 23:14 [PATCH] net: phy: Support for non-HW interrupt devices Woojung.Huh
2016-01-08 0:42 ` Andrew Lunn
2016-01-08 2:08 ` Florian Fainelli
2016-01-08 3:25 ` Woojung.Huh
2016-01-08 15:51 ` Andrew Lunn
2016-01-08 15:58 ` Woojung.Huh
2016-01-08 19:24 ` Andrew Lunn
2016-01-08 20:27 ` Florian Fainelli
2016-01-08 20:30 ` Woojung.Huh
2016-01-08 21:36 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108213640.GA28440@lunn.ch \
--to=andrew@lunn.ch \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).